Better documentation for "MINIMUM_IP_TARGET" and related variables

[guessi]

What would you like to be added:

Although MINIMUM_IP_TARGET have been documented, but there have no explanation what's the relationship between MINIMUM_IP_TARGET and --minimum-ip-target / --windows-minimum-ip-target? besides, it may need to explain why minimum-ip-target would pointed to minimumWindowsIPTarget variable as well.

Why is this needed:

Tried to study where the minimum-ip-target inside configmaps/amazon-vpc-cni came from, and I can see it's defined by minimumWindowsIPTarget under values.yaml

amazon-vpc-cni-k8s/charts/aws-vpc-cni/templates/configmap.yaml

Lines 19 to 26 in 110c30d

	data:
	enable-windows-ipam: {{ .Values.enableWindowsIpam | quote }}
	enable-network-policy-controller: {{ .Values.enableNetworkPolicy | quote }}
	enable-windows-prefix-delegation: {{ .Values.enableWindowsPrefixDelegation | quote }}
	warm-prefix-target: {{ .Values.warmWindowsPrefixTarget | quote }}
	warm-ip-target: {{ .Values.warmWindowsIPTarget | quote }}
	minimum-ip-target: {{ .Values.minimumWindowsIPTarget | quote }}
	branch-eni-cooldown: {{ .Values.branchENICooldown | quote }}

amazon-vpc-cni-k8s/charts/aws-vpc-cni/values.yaml

Lines 119 to 123 in 110c30d

	# - Windows Prefix Delegation settings
	enableWindowsPrefixDelegation: "false"
	warmWindowsPrefixTarget: 0
	warmWindowsIPTarget: 1
	minimumWindowsIPTarget: 3

After few minutes code tracing, I found it was initially introduced by PR#2715, but no explanation for why minimum-ip-target would initially pointed to minimumWindowsIPTarget ? I though it should be windows-minimum-ip-target?

Later on, I can see PR#2716 changed its default to 3, but still no explanation for why the default value changed?

I'm aware of the variables renamed at aws/amazon-vpc-resource-controller-k8s,

• Rename Windows warm/minimum IP targets amazon-vpc-resource-controller-k8s#370
• rename windows flags amazon-vpc-resource-controller-k8s#371

but it looks like the variable names does not reflect to what it should be.

Proposed change

templates/configmap.yaml

# https://github.com/aws/amazon-vpc-cni-k8s/tree/master?tab=readme-ov-file#warm_prefix_target-v190
warm-prefix-target: {{ .Values.warmPrefixTarget | quote }} 
windows-warm-prefix-target: {{ .Values.warmWindowsPrefixTarget | quote }} 

# https://github.com/aws/amazon-vpc-cni-k8s/tree/master?tab=readme-ov-file#warm_ip_target
warm-ip-target: {{ .Values.warmIPTarget | quote }} 
windows-warm-ip-target: {{ .Values.warmWindowsIPTarget | quote }} 

# https://github.com/aws/amazon-vpc-cni-k8s/tree/master?tab=readme-ov-file#minimum_ip_target-v160
minimum-ip-target: {{ .Values.minimumIPTarget | quote }} 
windows-minimum-ip-target: {{ .Values.minimumWindowsIPTarget | quote }} 

values.yaml

# https://github.com/aws/amazon-vpc-cni-k8s/tree/master?tab=readme-ov-file#warm_prefix_target-v190
warmPrefixTarget: xxx
warmWindowsPrefixTarget: xxx

# https://github.com/aws/amazon-vpc-cni-k8s/tree/master?tab=readme-ov-file#warm_ip_target
warmIPTarget: xxx
warmWindowsIPTarget: xxx

# https://github.com/aws/amazon-vpc-cni-k8s/tree/master?tab=readme-ov-file#minimum_ip_target-v160
minimumIPTarget: xxx
minimumWindowsIPTarget: xxx