-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in CodeArtifact tool flags to modify login behaviour #6634
Comments
Hi @whardier, Thanks for your post and the pull request. The CodeArtifact commands for the AWS CLI are maintained by the CodeArtifact team. I'll let them know about this suggestion. I'm not familiar with how this command works. Having an example of what you do now (with I can't provide a timeframe when the CodeArtifact team will be able to review, but I'll update when I hear something. |
Greetings! It looks like this issue hasn’t been active in longer than five days. We encourage you to check if this is still an issue in the latest release. In the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or upvote with a reaction on the initial post to prevent automatic closure. If the issue is already closed, please feel free to open a new one. |
Hmm. The close out process seems sub-optimal. |
Yea sorry about that. I'm going to re-open it. We have a new process for prioritizing contributions to review #6828 detailing improvements to the contributing process. So I will be re-opening the issue for tracking interest, and marking the PR as draft until the criteria in the new process is met. |
Thanks for your patience, it looks like this fell off of our radar. I'll try reaching out to the CodeArtifact team again to review this and share their feedback. |
Thank you for the feature request and the proposed PR #6633. A member of the CodeArtifact team has reviewed your submission and has the following feedback: The implementation in PR #6633 is quite specific, introducing a single new flag for pip/twine. The team's goal is to find a balance between simplicity/ease of use and the ability to customize. In this case, they feel the specific flag you've proposed represents a more advanced configuration than what the average user would require. As an alternative, the team suggests leveraging the existing AWS CLI commands While the team appreciates that your PR #6633 addresses the immediate need, they believe a more generic and extensible solution would better serve the broader customer base in the long run. This issue is not prioritized or planned at this time, but let us know if you have any further questions or suggestions for alternative solutions, and we may revisit this at a later date. |
This issue is now closed. Comments on closed issues are hard for our team to see. |
Is your feature request related to a problem? Please describe.
Pip and other CodeArtifact login tools need to modify login behaviour through the use of flags. Immediate use case is to alter which configuration setting is used with pip tool in order to avoid pulling through codeartifact upstreams (they are problematic) as well as speed up installation process (codeartifact is also slow)
Describe the solution you'd like
I've provided PR #6633 to best describe the solution. Allow for --flags and provide some fairly generic choices.
Describe alternatives you've considered
using --dry-run and sed to alter the command.. this is not a secure approach.
Additional context
Let's speed up build/deploy and make devs lives a smidge easier when utilizing CodeArtifact.
The text was updated successfully, but these errors were encountered: