Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransferUtilityDownloadDirectoryRequest is missing SSE-C properties #3147

Closed
1 of 2 tasks
lrocher opened this issue Jan 12, 2024 · 2 comments · Fixed by #3148
Closed
1 of 2 tasks

TransferUtilityDownloadDirectoryRequest is missing SSE-C properties #3147

lrocher opened this issue Jan 12, 2024 · 2 comments · Fixed by #3148
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet. s3

Comments

@lrocher
Copy link

lrocher commented Jan 12, 2024

Describe the feature

TransferUtilityUploadDirectoryRequest is missing the three SSE-C properties:

ServerSideEncryptionCustomerMethod
ServerSideEncryptionCustomerProvidedKey
ServerSideEncryptionCustomerProvidedKeyMD5

Use Case

I want to use TransferUtility.DownloadDirectory with SSE-C.
TransferUtility.UploadDirectory already manage this feature.

Proposed Solution

Add the properties and forward them in the DownloadDirectoryCommand to the TransferUtilityUploadDownload.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS .NET SDK and/or Package version used

AWSSDK.S3 3.7.305.10

Targeted .NET Platform

.NET Framework 4.7

Operating System and version

Windows

@lrocher lrocher added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 12, 2024
lrocher pushed a commit to lrocher/aws-sdk-net that referenced this issue Jan 12, 2024
@ashishdhingra ashishdhingra added s3 needs-review and removed needs-triage This issue or PR still needs to be triaged. labels Jan 16, 2024
@ashishdhingra
Copy link
Contributor

@lrocher Thanks for the PR. I will discuss this with team and would soon be reviewed.

@eddiemcs3 eddiemcs3 added p2 This is a standard priority issue and removed needs-review labels Jan 19, 2024
@dscpinheiro dscpinheiro added the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Jan 23, 2024
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet. s3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants