Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StaticValue constructor not returning nullable DateTime #3582

Closed
1 task
colmkavs opened this issue Dec 19, 2024 · 3 comments
Closed
1 task

StaticValue constructor not returning nullable DateTime #3582

colmkavs opened this issue Dec 19, 2024 · 3 comments
Labels
bug This issue is a bug. module/sdk-generated p2 This is a standard priority issue s Effort estimation: small v4

Comments

@colmkavs
Copy link

colmkavs commented Dec 19, 2024

Describe the bug

AWSSDK.QuickSight
TimeRangeFilterValue.StaticValue

When retrieving the object via the SDK, the constructor is not returning a nullable DateTime. It gets initialized as new DateTime() and if you have set the RollingDate property also, then a validation error is returned when using the object in CreateDashboardAsync()

_{"4 validation errors detected: Value 'TimeRangeFilterValue(staticValue=Mon Jan 03 00:00:00 UTC 1, rollingDate=RollingDateConfiguration(dataSetIdentifier=null, expression=*** REDACTED ***), parameter=null)' at 'definition.filterGroups.11.member.filters.1.member.timeRangeFilter.rangeMaximumValue' failed to satisfy constraint: Only 1 member of [staticValue, rollingDate, parameter] should be provided for structure TimeRangeFilterValue; Value 'TimeRangeFilterValue(staticValue=Mon Jan 03 00:00:00 UTC 1, rollingDate=RollingDateConfiguration(dataSetIdentifier=null, expression=*** REDACTED ***), parameter=null)' at_

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected Behavior

A Nullable DateTime value is allowed

Current Behavior

Initialised as a new DateTime

Reproduction Steps

Create the Dashboard via the CLI or UI with a rollingDateTime filter configured

Retrieve the Dashboard via the SDK DescribeDashboardDefinitionAsync
Publish the Dasboard (change its name to pass naming validation) using CreateDashboardAsync
Catch Validation Error Exception

Possible Solution

No response

Additional Information/Context

No response

AWS .NET SDK and/or Package version used

AWSSDK.QuickSight 3.7.411.5

Targeted .NET Platform

.NET 8

Operating System and version

Windows

@colmkavs colmkavs added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 19, 2024
@ashishdhingra ashishdhingra self-assigned this Dec 19, 2024
@ashishdhingra ashishdhingra added module/sdk-generated investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Dec 19, 2024
@ashishdhingra
Copy link
Contributor

@colmkavs Good morning. Thanks for opening the issue. You are perhaps affected by the side effect of AWS SDK for .NET v3 where such properties, although having Nullable backing field, always return GetValueOrDefault(). This behavior would be fixed in next major version v4 of AWS .NET SDK (which is currently in preview), please check code here.

Thanks,
Ashish

@ashishdhingra ashishdhingra added s Effort estimation: small v4 and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Dec 19, 2024
@ashishdhingra ashishdhingra removed their assignment Dec 19, 2024
@colmkavs
Copy link
Author

Thank you @ashishdhingra the v4 generated models have it addressed.

Copy link

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. module/sdk-generated p2 This is a standard priority issue s Effort estimation: small v4
Projects
None yet
Development

No branches or pull requests

2 participants