From 6b27d340e3c81df08eea4be6b55893fc25274266 Mon Sep 17 00:00:00 2001 From: Eamonn Faherty Date: Wed, 5 Jun 2019 16:52:06 +0100 Subject: [PATCH] preparing for release --- servicecatalog_puppet/aws.py | 6 ++++++ setup.py | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/servicecatalog_puppet/aws.py b/servicecatalog_puppet/aws.py index f2078195f..b4885f058 100644 --- a/servicecatalog_puppet/aws.py +++ b/servicecatalog_puppet/aws.py @@ -145,6 +145,12 @@ def provision_product( f"[{launch_name}] {account_id}:{region} :: Plan created, " f"changes: {yaml.safe_dump(response.get('ResourceChanges'))}" ) + if len(response.get('ResourceChanges')) == 0: + logger.warning(f"[{launch_name}] {account_id}:{region} :: There are no resource changes in this plan, " + f"running this anyway - your product will be marked as tainted as your CloudFormation changeset" + f"will fail but your product will be the correct version and in tact.") + + logger.info(f"[{launch_name}] {account_id}:{region} :: executing changes") service_catalog.execute_provisioned_product_plan(PlanId=plan_id) execute_status = 'EXECUTE_IN_PROGRESS' diff --git a/setup.py b/setup.py index ad0c4d183..51808745d 100644 --- a/setup.py +++ b/setup.py @@ -11,7 +11,7 @@ setuptools.setup( name="aws-service-catalog-puppet", - version="0.1.9", + version="0.1.10", author="Eamonn Faherty", author_email="aws-service-catalog-tools@amazon.com", description="Making it easier to deploy ServiceCatalog products",