Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Unsafe String Interpolation #653

Open
lcreid opened this issue Aug 2, 2022 · 2 comments
Open

Possible Unsafe String Interpolation #653

lcreid opened this issue Aug 2, 2022 · 2 comments

Comments

@lcreid
Copy link
Contributor

lcreid commented Aug 2, 2022

While refactoring for #642 , BootstrapFormGroupTest#test_append_and_prepend_button started outputting escaped strings instead of HTML. But the test hadn't changed. So the question is, did the code always allow unsafe strings to be passed in and be rendered without being checked for HTML-safeness?

@donv
Copy link
Collaborator

donv commented Sep 13, 2023

@lcreid Is there anything to do on this issue?

@lcreid
Copy link
Contributor Author

lcreid commented Sep 14, 2023

I'd like to leave this open, but I don't think it's high priority to address, since what I observed is that HTML was getting escaped, which is safer than if we were allowing through HTML that might not be safe to render.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants