feat(permissions): add command permissions #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c660412 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment was marked as outdated.
This comment was marked as outdated.
thewilloftheshadow
requested changes
Oct 5, 2024
There was a problem hiding this comment.
While this does technically work and will deploy, I'd like to add a bit more DX for it. Maybe passing an array from an enum of permissions?
Additionally, the subcommand and subcommand groups currently won't work. They don't error because they're still abstract within Carbon, but if you check the test command for them, you'll see the errors there.
mezotv
changed the title
thewilloftheshadow
force-pushed
the
command-permissions
branch
from
7c4a3e4 to
bcc8430
Compare
thewilloftheshadow
force-pushed
the
command-permissions
branch
from
bcc8430 to
39824c6
Compare
thewilloftheshadow
requested changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #155