Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: rebuilding the benchmarks should check for reproducibility #210

Open
abrown opened this issue Oct 25, 2022 · 0 comments
Open

ci: rebuilding the benchmarks should check for reproducibility #210

abrown opened this issue Oct 25, 2022 · 0 comments

Comments

@abrown
Copy link
Collaborator

abrown commented Oct 25, 2022

The point of the rebuild CI task is to ensure that we can reliably reproduce the benchmarks included with Sightglass. IIRC, there was a time when that task checked if the benchmark output had changed, e.g., with git diff --exit-code. That check is no longer in place but I believe it should be re-added so we can more confidently claim that we have reproducible benchmark builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant