Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android template to have a namespace declaration #394

Closed
1 of 2 tasks
cortinico opened this issue Jun 16, 2023 · 3 comments · Fixed by #399
Closed
1 of 2 tasks

Update Android template to have a namespace declaration #394

cortinico opened this issue Jun 16, 2023 · 3 comments · Fixed by #399
Assignees
Labels
bug Something isn't working

Comments

@cortinico
Copy link

Description

See this issue for the full report on why this is needed:

Let's update bob whenever is possible so that libraries organically get this change out.

Packages

  • create-react-native-library
  • react-native-builder-bob

Selected options

See above.

Link to repro

react-native-community/discussions-and-proposals#671

Environment

See above.

@cortinico cortinico added the bug Something isn't working label Jun 16, 2023
@atlj
Copy link
Collaborator

atlj commented Jun 19, 2023

Should we add an if statement to check the React Native version and apply it only if it's 0.73 or newer than 0.73, or is it safe to apply unconditionally? Would this work on React Native 0.72? If we are not sure I can test it before committing.

@cortinico
Copy link
Author

Nope it can't be added unconditionally. It should be applied only for 0.71+

@atlj
Copy link
Collaborator

atlj commented Jun 20, 2023

OK, thanks. We can add a version check if it's newer than 0.71, and we can specify the namespace 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants