Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency mismatch for can-validate-validatejs #64

Closed
rjgotten opened this issue Dec 20, 2021 · 2 comments · Fixed by #65
Closed

Dependency mismatch for can-validate-validatejs #64

rjgotten opened this issue Dec 20, 2021 · 2 comments · Fixed by #65

Comments

@rjgotten
Copy link

rjgotten commented Dec 20, 2021

npm ls can-validate-validatejs gives me (for CanJS 5.33.2 - but this will be no different for later versions, as 1.1.1 is the latest for the can-define-validate-validatejs package):

i.e. can-define-validate-validatejs is using a version range that is not compatible with the top-level can package and is leading to a duplicated local copy of the older dependency. This is in fact complicating a local workaround for another issue reported on can-validate-validatejs, freshly reported: canjs/can-validate-validatejs#44

I now have to concoct a build-step workaround which somehow swaps out both packages with fixed versions.

@rjgotten
Copy link
Author

rjgotten commented Dec 20, 2021

Literally the only line difference for can-validate-validatejs sofar (with aforementioned issue untreated) appears to be a "use strict" directive. Can you please just bump the dependency from the 0.1.x range into the 1.0.x range and publish a 1.1.2 version of the can-define-validate-validatejs package?

That should still fit version constraints, even for the 5.x range of the main can package.

@justinbmeyer
Copy link

Yeah, we can look into this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants