Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow faster lookup path that does not use undefinedObserves #117

Open
phillipskevin opened this issue Nov 8, 2017 · 0 comments
Open

Allow faster lookup path that does not use undefinedObserves #117

phillipskevin opened this issue Nov 8, 2017 · 0 comments

Comments

@phillipskevin
Copy link
Contributor

The current Scope.prototype._read does a lot of work to keep track of all observables that were checked when looking for a property:

// The **value was not found**, return `undefined` for the value.
// Make sure we listen to everything we checked for when the value becomes defined.
// Once it becomes defined, we won't have to listen to so many things.
Observation.addAll(undefinedObserves);

When most lookups will not walk the scope, this is a lot of unnecessary work.

We should make a faster path that does not do all of this and eventually remove this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant