Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Combobox unique value]: New value dev implementation #14006

Closed
3 tasks done
Tracked by #13975 ...
thyhmdo opened this issue Jun 15, 2023 · 1 comment · Fixed by #14935
Closed
3 tasks done
Tracked by #13975 ...

[Combobox unique value]: New value dev implementation #14006

thyhmdo opened this issue Jun 15, 2023 · 1 comment · Fixed by #14935

Comments

@thyhmdo
Copy link
Member

thyhmdo commented Jun 15, 2023

Ref link for implementation #13903

Acceptance Criteria

Allow users to type in a new value in the ComboBox and accept it as a new value

  • Add a new prop to enable the behavior
  • Typing and hitting enter should no longer clear the input as described in the spec: [Combobox unique value]: Design spec pass 2 (dev and a11y) #13903 (comment)
  • Evaluate if we need to modify the selectedItem state, but users could probably get the value without this even using target.value in the onChange callback if we have a ref on the input
@thyhmdo thyhmdo changed the title Allow users to type in a new value in the ComboBox and accept it as a new value [ComboBox] Allow users to type in a new value in the ComboBox and accept it as a new value Jun 15, 2023
@thyhmdo thyhmdo moved this to ⏱ Backlog in Design System Jun 15, 2023
@thyhmdo thyhmdo added this to Roadmap Jun 15, 2023
@github-project-automation github-project-automation bot moved this to Triage in Roadmap Jun 15, 2023
@sstrubberg sstrubberg moved this from Triage to Next in Roadmap Jun 15, 2023
@sstrubberg sstrubberg added this to the 2023 Q3 milestone Jun 15, 2023
@tay1orjones tay1orjones moved this from ⏱ Backlog to 🪆 Needs Refined in Design System Jun 15, 2023
@sstrubberg sstrubberg changed the title [ComboBox] Allow users to type in a new value in the ComboBox and accept it as a new value [ComboBox] New value implementation Jun 27, 2023
@sstrubberg sstrubberg moved this from 🪆 Needs Refined to ⏱ Backlog in Design System Jun 27, 2023
@sstrubberg sstrubberg moved this from Next to Now in Roadmap Aug 22, 2023
@sstrubberg sstrubberg modified the milestones: 2023 Q3, 2023 Q4 Sep 19, 2023
@tay1orjones
Copy link
Member

tay1orjones commented Sep 19, 2023

For this it seems the primary piece is to update the component to not clear the input after hitting enter if there is not a matched element in the listbox.

There was a question of if we needed to wait on this until we refactored ComboBox off of <Downshift> to instead use useComboBox #14684, but after some discussion we think the refactor shouldn't be necessary for this.

@tay1orjones tay1orjones moved this from ⏱ Backlog to 🚦 In Review in Design System Oct 19, 2023
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Oct 31, 2023
@github-project-automation github-project-automation bot moved this from Now to Completed in Roadmap Oct 31, 2023
@laurenmrice laurenmrice changed the title [ComboBox] New value implementation [Combobox unique value]: New value dev implementation Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants