-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: ComboBox - allowCustomValue no longer fires change event with custom value #16624
Comments
cc @preetibansalui |
@preetibansalui any chance someone can get some eyes on this one since it's a breaking change with a reproducible example? |
Hey @a88zach , let me take it on priority. Thanks for pointing this out. |
Hey @a88zach , The stackblitz link you shared is not working properly, can you please check and fix it. |
@preetibansalui, I just loaded the Stackblitz in an incognito window and it is working properly to reproduce the issue. In what way was it not working properly for you? |
@preetibansalui this one is related and caused by the change in #16283 |
@preetibansalui @sstrubberg anyway to push that PR through? It's been open for almost a month now |
Package
@carbon/react
Browser
Chrome
Package version
^1.58.0
React version
18.3.1
Description
Before version 1.58.0, a ComboBox with
allowCustomValue
set to true would fire the onChange event with an inputValue property after custom text is entered and the enter key is pressedThat event is no longer fired after #16283
Reproduction/example
https://stackblitz.com/edit/github-1ithgj-dpiqwg?file=src%2FApp.tsx
Steps to reproduce
Suggested Severity
Severity 2 = User cannot complete task, and/or no workaround within the user experience of a given component.
Application/PAL
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: