Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ComboBox - allowCustomValue no longer fires change event with custom value #16624

Closed
2 tasks done
a88zach opened this issue May 30, 2024 · 7 comments · Fixed by #16743
Closed
2 tasks done

[Bug]: ComboBox - allowCustomValue no longer fires change event with custom value #16624

a88zach opened this issue May 30, 2024 · 7 comments · Fixed by #16743
Assignees
Labels

Comments

@a88zach
Copy link
Contributor

a88zach commented May 30, 2024

Package

@carbon/react

Browser

Chrome

Package version

^1.58.0

React version

18.3.1

Description

Before version 1.58.0, a ComboBox with allowCustomValue set to true would fire the onChange event with an inputValue property after custom text is entered and the enter key is pressed

That event is no longer fired after #16283

Reproduction/example

https://stackblitz.com/edit/github-1ithgj-dpiqwg?file=src%2FApp.tsx

Steps to reproduce

  1. Load the Stackblitz and enter a custom value. Notice the Value label does not update with the custom entered text.
  2. Stop the dev server and change the version back to 1.57.0
  3. Restart the dev server and notice the ComboBox is working as expected

Suggested Severity

Severity 2 = User cannot complete task, and/or no workaround within the user experience of a given component.

Application/PAL

No response

Code of Conduct

@a88zach
Copy link
Contributor Author

a88zach commented May 30, 2024

cc @preetibansalui
caused by #16283

@a88zach
Copy link
Contributor Author

a88zach commented Jun 10, 2024

@preetibansalui any chance someone can get some eyes on this one since it's a breaking change with a reproducible example?

@preetibansalui
Copy link
Contributor

@preetibansalui any chance someone can get some eyes on this one since it's a breaking change with a reproducible example?

Hey @a88zach , let me take it on priority. Thanks for pointing this out.

@preetibansalui preetibansalui self-assigned this Jun 10, 2024
@preetibansalui
Copy link
Contributor

Hey @a88zach , The stackblitz link you shared is not working properly, can you please check and fix it.

@a88zach
Copy link
Contributor Author

a88zach commented Jun 11, 2024

@preetibansalui, I just loaded the Stackblitz in an incognito window and it is working properly to reproduce the issue. In what way was it not working properly for you?

@a88zach
Copy link
Contributor Author

a88zach commented Jun 24, 2024

@preetibansalui this one is related and caused by the change in #16283

#16856

@a88zach
Copy link
Contributor Author

a88zach commented Jul 9, 2024

@preetibansalui @sstrubberg anyway to push that PR through? It's been open for almost a month now

@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants