Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore data from localhost #9

Open
tidusia opened this issue Jul 18, 2019 · 2 comments · May be fixed by #16
Open

Ignore data from localhost #9

tidusia opened this issue Jul 18, 2019 · 2 comments · May be fixed by #16

Comments

@tidusia
Copy link

tidusia commented Jul 18, 2019

Hi !

Thanks for your very nice plugin.

By developing a React project, I've seen that the http://localhost:8080 is included in the analysis.

Maybe the plugin should ignore such cases because there is no internet bandwith usage associated with localhost project (exept API resquests or network images for example).
@supertanuki
Copy link
Collaborator

Hi Thibaud. The addon is for a large public, not only developers.
We, developers do not use only localhost url, but also something.localhost, something.dev, etc
Feel free to contribute to the code by adding a condition on the domain here: https://github.com/supertanuki/Carbonalyser/blob/master/script.js#L26

@batbyR batbyR linked a pull request Oct 6, 2019 that will close this issue
Open
@AAABBBCCCAAAA
Copy link

AAABBBCCCAAAA commented May 25, 2022 •
edited
Loading

This issue has been fixed here https://github.com/AAABBBCCCAAAA/Carbonalyser/blob/master/lib/carbonalyser/libStats.js#L2 with care of special urls from the browser (chrome:// and moz-ext)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore requests to localhost batbyR/Carbonalyser
3 participants
@supertanuki @tidusia @AAABBBCCCAAAA