Ignore requests to localhost #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedk
reviewed
Dec 4, 2020
| @@ -9,6 +9,8 @@ extractHostname = (url) => { | |||
| return hostname; | |||
| } | |||
|
|
|||
| isFromLocalMachine = (origin) => (origin === "localhost" || origin === "127.0.0.1"); | |||
There was a problem hiding this comment.
I think it will match more cases using a regexp like:
origin.match(/localhost|[0-9]{2,3}\.[0-9]{2,3}\.[0-9]{2,3}\.[0-9]{2,3}|::1|\.local|^$/gi)
There was a problem hiding this comment.
@cedk This regex don't even match 127.0.0.1. According to this article on IP classes I don't know if a regex would be powerful enough to determine a private IP address (and what about private networks extended on multiple places ?) Maybe an allow-list would better fit ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
Ignore request to "localhost" or "127.0.0.1" 🙈