Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception on mail validation link fails #3

Open
AndreasA opened this issue Nov 15, 2012 · 4 comments
Open

Exception on mail validation link fails #3

AndreasA opened this issue Nov 15, 2012 · 4 comments
Assignees

Comments

@AndreasA
Copy link

If the mail validation fails, there is an exception because in validateUser in the else branch of the instanceof if,
this is called $this->handleBehaviorResponse($this->doBehaviors($frontendUser, 'emailValidationFailure', $forward), $frontendUser);

However, handleBehaviorResponse expects $frontendUser to be of a correct type and therefore an exception is thrown.
Best would be to create a frontendUser before calling handleBehaviorResponse.

@zdavis
Copy link
Member

zdavis commented Nov 15, 2012

AndreasA,

Thanks for this. We'll see if we can put together a fix for it today.

best
Zach

@AndreasA
Copy link
Author

OK, thanks.

what needs to also be mentioned is that, of course, this issue also needs to be addressed for behaviors and decorators as those are also called with a forced type.

@zdavis
Copy link
Member

zdavis commented Nov 15, 2012

It's odd that behaviors or decorators are being called at all on an invalid frontendUser object. Those should only be called if the frontendUser has already been created. Can you provide me with a clear set of steps to reproduce the problem?

Zach

@AndreasA
Copy link
Author

Not, if I am using emailValidationFailure - there I want to use behaviors that are called on error, e.g. to add a flash message (which works fine without a valid frontend user)

Basically in the same case as the above error.

@ghost ghost assigned zdavis Nov 15, 2012
@ghost ghost assigned petersooley Nov 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants