From 602b56ca522c30fa0556a3dde6b02c3ba69a654b Mon Sep 17 00:00:00 2001 From: Punya Biswal Date: Tue, 5 Apr 2022 09:10:13 -0400 Subject: [PATCH] Fix retry stat measures to match those in grpc-java exactly (#2097) (#2102) * update descriptions of retry measures to match those in grpc-java exactly * change GRPC_CLIENT_RETRY_DELAY_PER_CALL from MeasureLong to MeasureDouble Co-authored-by: Mackenzie Starr --- .../contrib/grpc/metrics/RpcMeasureConstants.java | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/contrib/grpc_metrics/src/main/java/io/opencensus/contrib/grpc/metrics/RpcMeasureConstants.java b/contrib/grpc_metrics/src/main/java/io/opencensus/contrib/grpc/metrics/RpcMeasureConstants.java index 215e4de79..54047d34f 100644 --- a/contrib/grpc_metrics/src/main/java/io/opencensus/contrib/grpc/metrics/RpcMeasureConstants.java +++ b/contrib/grpc_metrics/src/main/java/io/opencensus/contrib/grpc/metrics/RpcMeasureConstants.java @@ -235,7 +235,7 @@ public final class RpcMeasureConstants { */ public static final MeasureLong GRPC_CLIENT_RETRIES_PER_CALL = Measure.MeasureLong.create( - "grpc.io/client/retries_per_call", "Number of retries per call.", COUNT); + "grpc.io/client/retries_per_call", "Number of retries per call", COUNT); /** * {@link Measure} for total number of transparent retries made during the client call. @@ -244,9 +244,7 @@ public final class RpcMeasureConstants { */ public static final MeasureLong GRPC_CLIENT_TRANSPARENT_RETRIES_PER_CALL = Measure.MeasureLong.create( - "grpc.io/client/transparent_retries_per_call", - "Number of transparent retries per call.", - COUNT); + "grpc.io/client/transparent_retries_per_call", "Transparent retries per call", COUNT); /** * {@link Measure} for total time of delay while there is no active attempt during the client @@ -254,9 +252,9 @@ public final class RpcMeasureConstants { * * @since 0.28 */ - public static final MeasureLong GRPC_CLIENT_RETRY_DELAY_PER_CALL = - Measure.MeasureLong.create( - "grpc.io/client/retry_delay_per_call", "Retry delay per call.", MILLISECOND); + public static final MeasureDouble GRPC_CLIENT_RETRY_DELAY_PER_CALL = + Measure.MeasureDouble.create( + "grpc.io/client/retry_delay_per_call", "Retry delay per call", MILLISECOND); /** * {@link Measure} for gRPC client error counts.