Update dependency jaeger-client to ~3.15.0 (#550)

* Update dependency jaeger-client to ~3.15.0 * Fix build - jaegertracing/jaeger-client-node#340
census-instrumentation · May 29, 2019 · 367db52 · 367db52
1 parent a157106
commit 367db52
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/packages/opencensus-exporter-jaeger/package-lock.json b/packages/opencensus-exporter-jaeger/package-lock.json
diff --git a/packages/opencensus-exporter-jaeger/package.json b/packages/opencensus-exporter-jaeger/package.json
@@ -64,6 +64,6 @@
   },
   "dependencies": {
     "@opencensus/core": "^0.0.13",
-    "jaeger-client": "~3.14.0"
+    "jaeger-client": "~3.15.0"
   }
 }
diff --git a/packages/opencensus-exporter-jaeger/src/jaeger.ts b/packages/opencensus-exporter-jaeger/src/jaeger.ts
@@ -82,7 +82,7 @@ export class JaegerTraceExporter implements Exporter {
                     .JAEGER_OPENCENSUS_EXPORTER_VERSION_TAG_KEY] =
         `opencensus-exporter-jaeger-${pjsonVersion}`;
     defaultTags[JaegerTraceExporter.TRACER_HOSTNAME_TAG_KEY] = os.hostname();
-    defaultTags[JaegerTraceExporter.PROCESS_IP] = Utils.ipToInt(Utils.myIp());
+    defaultTags[JaegerTraceExporter.PROCESS_IP] = Utils.myIp();
 
     // Merge the user given tags and the default tags
     const _tags: Tag[] = [...tags, ...Utils.convertObjectToTags(defaultTags)];

diff --git a/packages/opencensus-exporter-jaeger/test/test-jaeger.ts b/packages/opencensus-exporter-jaeger/test/test-jaeger.ts
@@ -93,7 +93,8 @@ describe('Jaeger Exporter', () => {
           testHostnameSeen = true;
           return;
         }
-        if (tag.key === JaegerTraceExporter.PROCESS_IP) {
+        if (tag.key === JaegerTraceExporter.PROCESS_IP &&
+            tag.vType === 'STRING') {
           testProcessIpSeen = true;
           return;
         }