Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sha1 and base64 functions #6

Open
robiwano opened this issue Oct 27, 2017 · 1 comment
Open

Remove sha1 and base64 functions #6

robiwano opened this issue Oct 27, 2017 · 1 comment
Labels
decision required

Comments

@robiwano
Copy link
Contributor

Having sha1 requires dependency on OpenSSL when it is not necessary. A filesystem library should ONLY provide the basic functionality to traverse folders, and provide means to read/write to file streams. Nothing more.

Hash/base64 etc. can, and should, be provided outside the library.
@chrisjd20
Copy link

I personally like the base64 functionality. Just my two-cents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
decision required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cgcostume @chrisjd20 @robiwano