Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chef_ingredient :upgradeshould reconfigure the service if the package version changes #189

Open
ryancragun opened this issue Aug 2, 2017 · 2 comments
Labels
Status: Good First Issue An issue ready for a new contributor. Type: Enhancement Adds new functionality.

Comments

@ryancragun
Copy link
Contributor

ryancragun commented Aug 2, 2017

Cookbook version

2.1.5

Chef-client version

12.21.3

Platform Details

Ubuntu 16.04 on AWS

Scenario:

chef_ingredient :upgrade should reconfigure the service if the package version changes. Without this, the it's impossible to use the resource for this behavior in an idempotent way. You will either have to reconfigure every time the chef client is run or use an external resource to handle notifying the service to restart.

eg:

# not idempotent, always reconfigures
chef_ingredient "server" do
  action [:upgrade, :reconfigure]
end

# requires an external execute
execute "chef-server-ctl reconfigure" do
  action :nothing
end

chef_ingredient "server" do
  action :upgrade
  notifies :run, execute['chef-server-ctl reconfigure'], :immediately
end

cc @schisamo @sdelano

@ryancragun ryancragun added the Type: Enhancement Adds new functionality. label Aug 2, 2017
@bkonick
Copy link
Contributor

bkonick commented Aug 31, 2017

Related to this, :upgrade should trigger a chef-server-ctl upgrade rather than just a reconfigure, right? I can't seem to get it to do that.

@tas50
Copy link
Contributor

tas50 commented Sep 9, 2017

I’m adding the Type: Jump In GitHub label to this issue. This is a great issue for someone to get their feet wet with and we’d love a PR to resolves the issue.

@wrightp wrightp assigned jaymalasinha and unassigned jaymalasinha Oct 5, 2017
@tas50 tas50 added Status: Good First Issue An issue ready for a new contributor. and removed Help: Good First Issue labels Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Good First Issue An issue ready for a new contributor. Type: Enhancement Adds new functionality.
Projects
None yet
Development

No branches or pull requests

4 participants