Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: await should automatically fetch script logs on failure #167

Open
patr1ckm opened this issue Mar 14, 2019 · 0 comments
Open

ENH: await should automatically fetch script logs on failure #167

patr1ckm opened this issue Mar 14, 2019 · 0 comments

Comments

@patr1ckm
Copy link
Contributor

patr1ckm commented Mar 14, 2019

The default error handling in await looks for error or exception in the returned response. This is NULL for e.g. scripts_get_custom_runs.

To increase the odds we fetch the logs automatically on error we can

  1. first check for error or exception
  2. if NULL, attempt to look up the logging function via civis:::get_script_fun or fetch_logs.

Here is an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant