Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the prompt format #207

Closed
Reinmar opened this issue Dec 23, 2024 · 2 comments · Fixed by #211
Closed

Improve the prompt format #207

Reinmar opened this issue Dec 23, 2024 · 2 comments · Fixed by #211
Assignees
Labels
intro Good first ticket. squad:platform Issue to be handled by the Platform team. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Dec 23, 2024

📝 Provide detailed reproduction steps (if any)

Image

✔️ Expected result

It's missing : (the other queries have it)

Also, we could suggest something (either as a default value or in the prompt itself) because I wasn't actually sure whether I should prefix the global with anything special.

The thing is that official plugins end up under CKEDITOR.*, while the ones created by pkg generator directly in the global scope. So, it might be wise to prefix the latter with something to make them more unique. Like CKFullScreen in this case?


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@Reinmar Reinmar added the type:bug This issue reports a buggy (incorrect) behavior. label Dec 23, 2024
@Reinmar
Copy link
Member Author

Reinmar commented Dec 23, 2024

Like this? I shortened the description because the example given sort of explains the same – that a plugin is exposed:

Enter the global name for UMD build (e.g. "CKMyPlugin"): ...

@Reinmar Reinmar added type:improvement This issue reports a possible enhancement of an existing feature. and removed type:bug This issue reports a buggy (incorrect) behavior. labels Dec 23, 2024
@pomek pomek added intro Good first ticket. squad:platform Issue to be handled by the Platform team. labels Dec 23, 2024
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Dec 23, 2024
@Reinmar
Copy link
Member Author

Reinmar commented Dec 23, 2024

Haha, so the prompt got me confused :D I thought that the global exposes the plugin. While it later learned that it actually exposes the packge's index.

Image

We need to do a better job at explaining this in the prompt 🙈

@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Dec 30, 2024
@psmyrek psmyrek self-assigned this Dec 30, 2024
psmyrek added a commit that referenced this issue Dec 31, 2024
Other (generator): The package generator prompt displays the suggested name for the UMD build. The name is created from the plugin name and prefixed with the `CK`. Closes #207.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Dec 31, 2024
@CKEditorBot CKEditorBot added this to the iteration 82 milestone Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intro Good first ticket. squad:platform Issue to be handled by the Platform team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
4 participants