Please implement impl From<Cow<'static, str>> for StyledStr

[teythoon]

Please complete the following tasks

• I have searched the discussions
• I have searched the open and rejected issues

Clap Version

4.5.20

Describe your use case

We have a type representing a group of arguments that we can #[command(flatten)] into a number of subcommands. We want to tweak the help texts for some of them, but most will use the default help text. The default help text is a &'static str, but the tweaked versions would have to be heap allocated. Now, we'd like to avoid the heap allocations for the vast majority of help texts.

Describe the solution you'd like

We'd like to use Arg::new(..).help(maybe_modify("the default help text")) where maybe_modify returns a Cow<'static, str>.

Alternatives, if applicable

The alternative is to heap allocate even the help texts we don't want to change, i.e. do Arg::new(..).help(maybe_modify("the default help text")) where maybe_modify returns a String. This works today, but meh.

Additional Context

No response

[epage]

I'm fine with someone posting a PR for this. If we have other places where there is a From from either 'static or owned, we should add it there as well.

Note: this could be worked around instead by having maybe_modify return a StyledStr and then you can call the separate Froms for each case.

[teythoon]

Returning StyledStr is a good idea in the mean time, thanks!

[zaira-bibi]

Hey! I'd like to try my hand at this please.

[zaira-bibi]

Hi @epage, I've opened a PR for this issue. I'm not sure where I was supposed to write the tests for this, so guidance in that would really be appreciated. Thanks!