-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work with latest version of node-host #32
Comments
I'm still debating between 1.0.0 and contributing to https://github.com/clojure-vim/neovim-client to allow hosting. Is anyone using plugins that require node-host 1.0.0? |
v1.0.0 was only released 10 days ago, so there probably aren't any plugins that rely on it currently. I'm using quite a bit plugins and this is the only one I have that relies on node-host, so I can personally stay on v0.0.1 for as long as I want. |
I downgraded node-host but I'm not unable to get |
@diffractometer I did not run into any issues with downgrading. Did you run |
@Kelvin-Chen Thanks! That worked! Derp, I should have tried that. 🍻 <~ on me. Cheers. |
@snoe I'm not using any plugins which require node-host 1.0.0. |
I have this issue and honestly I think I've tried all combinations of all the random weird commands one should perform. I even tried downgrading node-host. All I get is just:
|
I was able to undo the breaking changes, but with quite a bit of fiddling. I'm using
I don't seem to get the full git repository; I run
So my first thought was to wipe away what
Next I checked out the reference to the non-breaking build, and installed its dependencies:
This only fixed part of the problem, though. It seems there's a global dependency on So I took a shot in the dark and moved the
Afterwards opening vim and running |
All you need to do is cd to plugged/node-host, git checkout v0.0.1, npm install, restart vim and run :UpdateRemotePlugins. |
@snoe This is the only plugin I'm using with |
not even node-host |
@snoe Since this is a plugin not only for Clojure development, and node-host has been merged into neovim, I think it's better to support node-host than |
@markx Unfortunately, it looks like we're still stuck with node-client and it's dependency tree. You're right though, and I think it's a good time to bring this plugin back inline with everything. |
Ok I think I've got things updated to run with the HEAD version of neovim. I'd like at least one person to confirm things look ok for them before closing this off. Thanks for your patience. |
It doesn't work for me, yet.
Neovim doesn't have the Node provider available, I made created an issue in neovim |
I created an issue with neovim, but there seems to be a bug in CheckHealth If I run:
It looks like nvim-parinfer is installed. If i open a lisp file and go into insert mode I get:
|
@duikboot try to |
After updating everything, I also see these errors:
|
I get errors in insert mode and it appears that plugin commands/functions aren't registering, will investigate. Update: OK I see what the issue is, it depends on the |
Still doesn't work for me It doesn't work yet on Fedora 26. CheckHealth still gives me:
|
@billyvg thanks for helping with this. What should cause the If there was a single neovim-client file (or es6 module) I could bring it in in the same way as I bring in parinfer. Unfortunately the nested requires aren't supported by cljs https://clojurescript.org/reference/javascript-module-support#node.js-module. In the meantime @duikboot I think you can run |
@billyvg I pushed a branch called |
I had the same issue w.r.t I'm assuming that this is just a workaround? |
@snoe It works now, I also had to add the node-modules bin directory to my $PATH Thanks a lot |
Is this issue still happening on neovim HEAD? |
Ik works for me |
@cbcoutinho I also fixed by |
I get the same error as soon as a clj file is opened.
What is |
I don't have enough knowledge about Clojure/Javascript/ClojureScript to expand further on why you need to do it this way. |
I don't have any javascript in my project so do not use |
Running |
i am still getting:
updated npm/node before i tried, i see |
I'm having the same problem. Running |
I'm going to suggest people take a look at https://github.com/eraserhd/parinfer-rust it's early days but it's working right now without the need for remote plugins. |
parinfer rust works as expected out of the box. thank you! |
When I run it with the latest version of node-host (v1.0.0) I get
Unknown function: ParinferIndent
. Downgrading back to v0.0.1 fixes the problem.neovim/node-host@0c116cb mentions that breaking changes are incoming, so it looks like whatever changes they made broke this plugin.
Are there any plans to support the new node-host or should I just stay on v0.0.1 for now?
The text was updated successfully, but these errors were encountered: