Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka Cloud events implementation does not provide support For Null, Ignore Key types #313

Open
Abuntxa opened this issue Sep 25, 2024 · 2 comments

Comments

@Abuntxa
Copy link

Abuntxa commented Sep 25, 2024

The current extensión methods that allow transforming to and from CloudEvents into Kafka messages expects always messages of type Message<string?, byte[]> where the first generic template parameter is the type of Key in the Kafka messages.

When using the KafkaConsumer or producer it is usual to use the types "Confluent.Kafka.Ignore" or "Confluent.Kafka.Null" too that would handle messages like the following:
Message<Confluent.Kafka.Ignore, byte[]>
Message<Confluent.Kafka.Null, byte[]>

@jskeet
Copy link
Contributor

jskeet commented Sep 25, 2024

This is something I would be unable to take on myself, not being familiar with Kafka. (I basically inherited the current code to maintain.) I'd welcome a pull request that addresses the concern, preferably without any breaking changes to the existing API.

@Abuntxa
Copy link
Author

Abuntxa commented Sep 26, 2024

I have provided the following PR as an implementation with no breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants