Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage/spanner.go could use some tests. #20

Open
bgood opened this issue Mar 17, 2021 · 1 comment
Open

storage/spanner.go could use some tests. #20

bgood opened this issue Mar 17, 2021 · 1 comment
Assignees
@iyertalks
Labels
P1 Priority 1
Milestone
Merge Baseline

Comments

@bgood
Copy link
Collaborator

bgood commented Mar 17, 2021

This file could really use some test cases. This is where most of the important stuff is happening; The translation from DynamoDB to Spanner and back. Having test cases for it automatically also means that we have a sort of documentation of what is supported and what is not.

Originally posted by @olavloite in #3 (comment)
@bgood bgood mentioned this issue Mar 17, 2021
Merged
2 tasks
@bgood bgood added the P1 Priority 1 label Jul 2, 2021
@bgood bgood added this to the Merge Baseline milestone Sep 16, 2021
@iyertalks
Copy link
Collaborator

Please assign to me.

@bgood bgood mentioned this issue Oct 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iyertalks iyertalks

Labels
P1 Priority 1
Projects
None yet
Milestone
Merge Baseline
Development

No branches or pull requests
2 participants
@bgood @iyertalks