Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbrella issue of minor breaking changes #210

Open
3 tasks
apstndb opened this issue Nov 23, 2024 · 0 comments
Open
3 tasks

Umbrella issue of minor breaking changes #210

apstndb opened this issue Nov 23, 2024 · 0 comments

Comments

@apstndb
Copy link
Contributor

apstndb commented Nov 23, 2024

This issue is memo of minor breaking changes(non-mandatory, but better to do).

  • TABLESAMPLE clause may be better to move to FROM and JOIN clause from all TableExpr implementations
  • AsAlias([AS] name) may be better to be renamed as Alias, and call AS name as AsAlias.
    • Discussed in GCPUG Slack
    • Related discussion: we have not yet concluded, but I think there is a benefit to name expr AS name(NamedExpr?), and expr [AS name] (ZetaSQL's ASTExpressionWithOptAlias)
  • SimpleType can be removed because NamedType can handle all SimpleType.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant