Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrench create behavior changed to return error with empty schema file #125

Open
asetty opened this issue Dec 19, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@asetty
Copy link

asetty commented Dec 19, 2024

Expected Behavior

I expected the database to be created with no tables other than the migration table. This used to be the behavior before migration to memefish

Current Behavior

Error command: create, version: v1.11.1
Failed to execute the operation to Cloud Spanner, DDL statement is empty.

Steps to Reproduce

Run wrench create with empty schema.sql file

Context (Environment)

  • wrench version: 1.11.1
  • spanner emulator

There is a simple fix to check for empty strings when parsing the DDL I will post a PR for.

@asetty asetty added the bug Something isn't working label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant