Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected spelling mistakes #1091

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Corrected spelling mistakes #1091

merged 1 commit into from
Oct 12, 2023

Conversation

ravixis29
Copy link
Contributor

<Signed-off-by: Ravi Kumar [email protected]>

@aliok
Copy link
Member

aliok commented Sep 25, 2023

@ravixis29 Thanks for the PR, looks great.

Can you amend your commit to make sure it is signed off?

git commit --amend --signoff

@ravixis29
Copy link
Contributor Author

I have signed off it. Kindly check and confirm @aliok

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @ravixis29!

@nate-double-u
Copy link
Member

nate-double-u commented Oct 4, 2023

Before we merge this, we still need you to sign off on the commits. You can find instructions here: https://github.com/cncf/mentoring/pull/1091/checks?check_run_id=17111169388

I see that you did sign off, but the settings still aren't quite correct, see the last line from the link above:

Commit sha: f9e74eb, Author: [email protected], Committer: [email protected]; Expected "[email protected] [email protected]", but got "Ravi Kumar [email protected]".

@ravixis29 ravixis29 force-pushed the main branch 4 times, most recently from 99ea794 to f61ead4 Compare October 7, 2023 18:40
@nate-double-u
Copy link
Member

Thanks for making the update!

@nate-double-u nate-double-u merged commit 2070f4e into cncf:main Oct 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants