Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrained lines #42

Open
coatless opened this issue Sep 22, 2023 · 2 comments
Open

Constrained lines #42

coatless opened this issue Sep 22, 2023 · 2 comments
Labels
t: feature-request Request the addition of a new feature
Milestone

Comments

@coatless
Copy link
Owner

Sometimes we might want to have code like:

my_function = function(x) {
  # Code here
  ...
  ...
  # end code
}

Only the lines between code here and end code should be editable.

The constrained-editor-plugin for monaco editor might help with that, c.f.

microsoft/monaco-editor#953 (comment)

Demo of lines being constrained in the playground:

https://constrained-editor-plugin.vercel.app/playground

@jooyoungseo any issues with accessibility if only portions of the code cell are editable inside Monaco? The main signal for the areas being editable would come from a visual overlay.

@coatless coatless added the t: feature-request Request the addition of a new feature label Sep 22, 2023
@jooyoungseo
Copy link
Contributor

@coatless -- Thanks for considering accessibility before introducing new features :) I have tested the playground, and have not found any accessibility issues. Works nicely with screen readers!

@coatless
Copy link
Owner Author

@jooyoungseo thanks for the quick turn around on checking out the option :) I'll work toward incorporate it.

@coatless coatless added this to the 4.x milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: feature-request Request the addition of a new feature
Projects
None yet
Development

No branches or pull requests

2 participants