New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement setState #15

Open

ghost opened this issue Apr 3, 2017 · 0 comments

ghost commented Apr 3, 2017 •

edited by ghost

Loading

requires factoring code out of $onChanges

notes:

ensure componentWillReceiveProps event is not triggered on setState
componentWillReceiveProps can call setState
nextState shouldn't be merged into this.state until after shouldComponentUpdate is called (that is, when implementing setState, dont just assign into this.state... store that state in temporary variable and trigger cycle without componentWillReceiveProps)
make this.state public

ghost mentioned this issue

fix shouldComponentUpdate #11

Merged

ghost mentioned this issue

implement setState #19

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment