From b268d7713abf8d573393699a49289a2d1db856f0 Mon Sep 17 00:00:00 2001 From: Marius Vollmer Date: Fri, 13 Dec 2024 12:17:43 +0200 Subject: [PATCH] lib: Give secondary buttons more contrast in toolbars Secondary buttons have a transparent background by default, which needs more contrast on grey backgrounds like in toolbars. --- pkg/lib/patternfly/patternfly-5-overrides.scss | 11 +++++++++++ test/reference | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/pkg/lib/patternfly/patternfly-5-overrides.scss b/pkg/lib/patternfly/patternfly-5-overrides.scss index 8200d4464551..0ae9881e05db 100644 --- a/pkg/lib/patternfly/patternfly-5-overrides.scss +++ b/pkg/lib/patternfly/patternfly-5-overrides.scss @@ -407,3 +407,14 @@ select.pf-v5-c-form-control { html:not(.pf-v5-theme-dark) .pf-v5-c-menu-toggle:not(.pf-m-primary) { background-color: var(--pf-v5-global--BackgroundColor--100); } + +/* Give secondary buttons a white/grey background instead of their + default transparent one. This gives them better contrast in + toolbars. +*/ +.pf-v5-c-button.pf-m-secondary { + background-color: var(--pf-v5-global--BackgroundColor--100); + .pf-v5-theme-dark & { + background-color: var(--pf-v5-global--BackgroundColor--400); + } +} diff --git a/test/reference b/test/reference index b8704b853a9e..89b3ed85d000 160000 --- a/test/reference +++ b/test/reference @@ -1 +1 @@ -Subproject commit b8704b853a9ebd0f137c55ea95bc2e8b818a3148 +Subproject commit 89b3ed85d0006a22e767f6da77513a335b97558b