Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cinema mode in Edge #2763

Open
androidghosh opened this issue Jan 3, 2025 · 3 comments
Open

Cinema mode in Edge #2763

androidghosh opened this issue Jan 3, 2025 · 3 comments
Labels
good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Riddle up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@androidghosh
Copy link

androidghosh commented Jan 3, 2025

Concise Description

When I turn on cinema mode, and reload, who whole video is not playable anymore. This happens only when I'm logged in, does not happen when i'm in incognito mode. I'm using all default settings and also any other extension is turned off. Video I was testing https://www.youtube.com/watch?v=gFU0r5ZpAc0

image

Browser/s

Edge
Chrome

Other Browser:

Does not happen on Chrome

'Steps to reproduce' - Which of our features is required for the bug to happen?

Turn on cinema mode and the two other options below it

Since when?

Just installed it first time today

Does the bug still happen when you log out of YouTube?

No

..No? Then please paste your yt.config_.EXPERIMENT_FLAGS. Twice (With the error & Without)

https://privatebin.net/?ce55824cf7624878#7XNJrJZk1iAS24nxwYo51Su5y1zpo1sRMTsxvS3w9Hju

Are any errors or related log-messages shown in the Browser-Console? (F12)

image

Tested as the only active extension? (incognito mode or another browser users):

Yes

Expected preferred behavior:

No response

ImprovedTube Version

No response

Your Settings (From the Extension's -Hamburger menu > Settings > Backup & reset > Export settings)

No response

Your YouTube-Document

No response

OS / Device:

Windows 11

@androidghosh androidghosh added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Jan 3, 2025
@androidghosh
Copy link
Author

androidghosh commented Jan 3, 2025

UPDATE: after logging out and then in, the problem was solved. But it was a bit weird to have this problem. I still want someone to look at this.

@ImprovedTube
Copy link
Member

hi! and thanks @androidghosh your flags were added to #2251, increasing the list by a lot (149 flags.)

  • the feature is new Add Cinema Mode #2149 thanks to @SanderDebets

  • it overlays everything but gives the player a higher layer number (z-Index)

  • alternatively check the feature (general:) Dim, except what i hover over.

  • We could allow to set the values (dim and duration) and merge the two features into one.

  • We always need to name features, document, and keep it tidy (merge features or nested navigation.) This might be easier than editing a wikipedia article and very relevant. (Strange to see ratios like a million but very little development let alone contributions without coding)

@ImprovedTube ImprovedTube changed the title 🐞Bug in cinema mode in Edge Cinema mode in Edge Jan 4, 2025
@ImprovedTube
Copy link
Member

(we can remove the label bug at another later review)

@ImprovedTube ImprovedTube removed the Bug Bug or required update after YouTube changes label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Riddle up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

2 participants