Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning instead of Error in case of no NSDoc files are found; More descriptive warning message #275

Closed
pascalwilbrink opened this issue Oct 18, 2023 · 1 comment · Fixed by #314
Labels
Refinement done Ready for development

Comments

@pascalwilbrink
Copy link
Member

pascalwilbrink commented Oct 18, 2023

When no NSDoc files are found, a log Event and a snackbar are shown in the frontend.

The snackbar should be removed.
We should check with openscd if we want to divide logging an Error and showing the Snackbar in the bottom into 2 seperate things or that we want to add a flag to the event to skip showing the snackbar

@Sander3003
Copy link
Member

If I open demo.compas.energy right now, this is what I see:

image

The console states:
image

As an CoMPAS user
I would like to see more clear warning messages
In order to judge if the tool is stable enough to build substations

Posposed solution:
Process NSD loading erros as warning
Add more detail to the waning: Cannot load file XYZ

@Sander3003 Sander3003 changed the title Snackbar pops up when no NSDoc files are found Warning instead of Error in case of no NSDoc files are found; More descriptive warning message Dec 6, 2023
@juancho0202 juancho0202 added the Refinement done Ready for development label Jan 31, 2024
@Stef3st Stef3st linked a pull request Feb 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refinement done Ready for development
Projects
Development

Successfully merging a pull request may close this issue.

3 participants