Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler warnings that need to be dealt with #2

Open
3 of 7 tasks
comamitc opened this issue Jan 24, 2016 · 2 comments
Open
3 of 7 tasks

Compiler warnings that need to be dealt with #2

comamitc opened this issue Jan 24, 2016 · 2 comments
Labels
Milestone

Comments

@comamitc
Copy link
Owner

These are largely due to things from clojure that aren't exposed or suitable for clojurescript. There are some weird instances where rewrite-cljs can't find methods within it self but these might be from compilation issues further up the chain.

  • WARNING: Use of undeclared Var rewrite-clj.node/raw-meta-node at line 74 out/rewrite_clj/parser/core.cljs
  • WARNING: Use of undeclared Var rewrite-clj.node/length at line 49 out/rewrite_clj/zip/base.cljs
  • WARNING: Use of undeclared Var rewrite-clj.node/length at line 49 out/rewrite_clj/zip/base.cljs
  • WARNING: Use of undeclared Var rewrite-clj.node/value at line 55 out/rewrite_clj/zip/base.cljs
  • WARNING: Use of undeclared Var rewrite-clj.zip/left* at line 104 src/cljsfmt/core.cljs
  • WARNING: Use of undeclared Var rewrite-clj.zip/up* at line 106 src/cljsfmt/core.cljs
  • WARNING: Use of undeclared Var rewrite-clj.node/value at line 152 src/cljsfmt/core.cljs
@comamitc comamitc added the bug label Jan 24, 2016
@comamitc comamitc added this to the 0.1.0 milestone Jan 24, 2016
@comamitc
Copy link
Owner Author

There are many large differences in rewrite-cljs but thinking about issuing a PR to it to clean it up and make the port as minimal as possible.

import-vars is the one of the main things missing:
clj-commons/potemkin#31 (comment)

@comamitc
Copy link
Owner Author

The last 4 errors above are present on the parent library rewrite-cljs. I will open up an issue for those at a later date. (or submit a PR)

edit: clj-commons/rewrite-cljs#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant