Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cvat-sdk python package #28672

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

achimgaedke
Copy link

@achimgaedke achimgaedke commented Dec 21, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 21, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cvat-sdk/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/cvat-sdk/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12444332200. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 21, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cvat-sdk/meta.yaml) and found some lint.

Here's what I've got...

For recipes/cvat-sdk/meta.yaml:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

For recipes/cvat-sdk/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12446361931. Examine the logs at this URL for more detail.

@achimgaedke achimgaedke force-pushed the cvat-sdk branch 3 times, most recently from f6378c7 to 25827e1 Compare December 21, 2024 15:29
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 21, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cvat-sdk/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/cvat-sdk/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12468942456. Examine the logs at this URL for more detail.

@achimgaedke achimgaedke changed the title Adding cvat-sdk python package Adding cvat-sdk and cvat-cli python package Dec 21, 2024
@achimgaedke achimgaedke changed the title Adding cvat-sdk and cvat-cli python package Adding cvat-sdk python package Dec 21, 2024
@achimgaedke
Copy link
Author

achimgaedke commented Dec 21, 2024

Hey Maintainers!

@conda-forge/help-python ready for review, thank you!
I'm done with editing/fixing. Here's how far I got.

This recipe produces 3 outputs, cvat-sdk and two "extras" packages (-masks and -pytorch).

The windows test fails for cvat-sdk-pytorch, all other platforms succeed:

Could not solve for environment specs
The following packages are incompatible
\u251c\u2500 cvat-sdk-pytorch =2.24.0 pyhd8ed1ab_0 is not installable because it requires
\u2502 \u2514\u2500 pytorch =* , which does not exist (perhaps a missing channel);
\u251c\u2500 pytorch =
* does not exist (perhaps a typo or a missing channel);
\u2514\u2500 torchvision =* * does not exist (perhaps a typo or a missing channel).

It depends on the broken pytorch providing package, which is not available due to the broken pytorch-cpu windows build - conda-forge/pytorch-cpu-feedstock#32

The cvat-sdk-pytorch noarch package for Windows is still useful in combination with the pytorch channel/gpu built provided by nvidia. I haven't managed to exclude windows from the tests without failing the linting stage.

This sounds to me like the exception mentioned in item 3 at https://conda-forge.org/docs/maintainer/guidelines/#generalities .

Any advice on this?

- tuspy ==0.2.5
- typing_extensions >=4.2.0
- python-dateutil >=2.5.3
- setuptools >=21.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless this uses pkg_resources, it is unlikely that it requires setuptools at runtime.

Suggested change
- setuptools >=21.0.0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Again grayskull generated) will remove it and see what happens.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the requirements list in the pip package. Now removed - pkg_resouces isn't used.

- name: cvat-sdk
- name: cvat-sdk-masks
requirements:
host: &id001
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Author

@achimgaedke achimgaedke Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a yaml anchor for this section not to copy it below again. - Grayskull generated it.
https://support.atlassian.com/bitbucket-cloud/docs/yaml-anchors/

If you like to have the sections written out I can replace those references by copying. Maybe that helps the conda recipe manager ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcelotrevisani when was this implemented in grayskull?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grayskull pypi --maintainers achimgaedke --extras-require-all --extras-require-split cvat-sdk

with grayskull 2.7.3 - not sure since when this uses anchors.

@achimgaedke
Copy link
Author

achimgaedke commented Dec 28, 2024

@conda-forge/help-python - Could you please review/consider this recipe for merging?

This recipe produces 3 outputs, cvat-sdk and two "extras" packages (-masks and -pytorch) - mimicking the pip package's extras.

The windows test fails for cvat-sdk-pytorch, all other platforms succeed:

    Could not solve for environment specs
    The following packages are incompatible
    \u251c\u2500 cvat-sdk-pytorch =2.24.0 pyhd8ed1ab_0 is not installable because it requires
    \u2502 \u2514\u2500 pytorch =* , which does not exist (perhaps a missing channel);
    \u251c\u2500 pytorch = * does not exist (perhaps a typo or a missing channel);
    \u2514\u2500 torchvision =* * does not exist (perhaps a typo or a missing channel).

It depends on the pytorch package, which is not available for windows due to the broken pytorch-cpu windows build - conda-forge/pytorch-cpu-feedstock#32

The cvat-sdk-pytorch noarch package for Windows is still useful in combination with the pytorch channel/gpu built provided by nvidia. I haven't managed to exclude windows from the tests without failing the linting stage.

This sounds to me like the exception made to failing pipelines mentioned in item 3 at https://conda-forge.org/docs/maintainer/guidelines/#generalities .

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants