-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding cvat-sdk python package #28672
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/cvat-sdk/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12444332200. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/cvat-sdk/meta.yaml:
For recipes/cvat-sdk/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12446361931. Examine the logs at this URL for more detail. |
f6378c7
to
25827e1
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/cvat-sdk/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12468942456. Examine the logs at this URL for more detail. |
edf5826
to
a606591
Compare
a606591
to
cea545d
Compare
Hey Maintainers! @conda-forge/help-python ready for review, thank you! This recipe produces 3 outputs, cvat-sdk and two "extras" packages ( The windows test fails for
It depends on the broken The This sounds to me like the exception mentioned in item 3 at https://conda-forge.org/docs/maintainer/guidelines/#generalities . Any advice on this? |
recipes/cvat-sdk/meta.yaml
Outdated
- tuspy ==0.2.5 | ||
- typing_extensions >=4.2.0 | ||
- python-dateutil >=2.5.3 | ||
- setuptools >=21.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless this uses pkg_resources
, it is unlikely that it requires setuptools at runtime.
- setuptools >=21.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Again grayskull generated) will remove it and see what happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the requirements list in the pip package. Now removed - pkg_resouces isn't used.
- name: cvat-sdk | ||
- name: cvat-sdk-masks | ||
requirements: | ||
host: &id001 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a yaml anchor for this section not to copy it below again. - Grayskull generated it.
https://support.atlassian.com/bitbucket-cloud/docs/yaml-anchors/
If you like to have the sections written out I can replace those references by copying. Maybe that helps the conda recipe manager ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcelotrevisani when was this implemented in grayskull?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grayskull pypi --maintainers achimgaedke --extras-require-all --extras-require-split cvat-sdk
with grayskull 2.7.3 - not sure since when this uses anchors.
@conda-forge/help-python - Could you please review/consider this recipe for merging? This recipe produces 3 outputs, The windows test fails for
It depends on the The This sounds to me like the exception made to failing pipelines mentioned in item 3 at https://conda-forge.org/docs/maintainer/guidelines/#generalities . |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).