Shop Features on Develop?

[SpeedyD]

This has kinda been a long time coming, and I'm not sure why I'm starting this discussion right now, in here, but..

I sincerely think that @ScuffedNewt's Shop Features extension (https://github.com/ScuffedNewt/lorekeeper/tree/extension/shop-features) should be part of v3. Or, at this point, v3.1 I guess.

It's got a lot of features which, in my personal opinion, should've been part of core ages ago, and despite that I've asked and suggested this before, it has yet to happen.. Hence this discussion thread.. issue.. whatever.

Let's just get this implemented into Dev. It needs to be a Core Ext, and you know it.

[itinerare]

Yeah, it's been in discussion for some time.

[ScuffedNewt]

As much as I agree, shop features are waiting on some updates/changes I haven't made that will fundamentally modify how shops work. Until this is complete, I don't think it's worth the effort to merge since it also restricts my own ability to work on it

Shop features is definitely one of the extensions that are possibly seen as a "must" on a new install, but its not ready to be core yet

[SpeedyD]

What sort of work does it still need? Is there perhaps something the rest of us can help with??

[ScuffedNewt]

The plan is:

• entirely restructure shop costs similar to shop stock
• fix / rework timed stock to be configurable since there has been confusion about how it works, and since this part was done by moif (IIRC) its probably a good idea for myself to understand it
• add random shop stock (contingent on timed stock)
• user shops (probably)

I'm not sure if other users can assist since I'm not able to review code in-depth for things like these and its easier for me to write it myself and understand it if that makes sense

[itinerare]

User shops seem firmly like something that should remain ext territory, to me.

[ScuffedNewt]

It can always be merged prior to the user shops feature

[itinerare]

No qualms with that.

[SpeedyD]

Please make user shops a separate entity. ^^;

As for the rest, I understand.. I guess it makes sense you'd like to finish things up yourself..

While on the subject.. Is there by the way any means of requesting new functions? I had hoped there would be a way to set it so that certain stock (or even an entire store) is available only during specified time periods, repeating yearly/monthly etc..

[ScuffedNewt]

I can add that to the todo yep