Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Gradle files #106

Open
3 tasks
Apisov opened this issue Apr 23, 2020 · 4 comments
Open
3 tasks

Clean Gradle files #106

Apisov opened this issue Apr 23, 2020 · 4 comments

Comments

@Apisov
Copy link
Member

Apisov commented Apr 23, 2020

TODO

  • Use separate variable for versions
  • Clean commented code

Bonus

  • Perhaps use Kotlin instead of Groovy
@redbassett redbassett self-assigned this Apr 23, 2020
@redbassett
Copy link
Contributor

covidwatchorg/covidwatch-android-tcn#121 splits out some new variables and cleans up a little bit of commenting. Does your second bullet point involve commented out code, or just refer to cleaning up documenting comments? I couldn't find any of the former.

@nkumarcc
Copy link
Contributor

nkumarcc commented Apr 27, 2020

@redbassett pulled covidwatchorg/covidwatch-android-tcn#121, it's awesome but I'm not sure that hits the first point completely in the issue so I'm not hitting the checkbox. I'm interpreting checkbox 1 as about versions of the app as well. Correct me if I'm wrong

@redbassett
Copy link
Contributor

@nkumarcc Yeah, I'm not considering that PR to have resolved the first check here until @Apisov says otherwise.

@redbassett redbassett removed their assignment May 3, 2020
@Apisov
Copy link
Member Author

Apisov commented May 18, 2020

I must've missed the comments -- sorry for such a late reply. That PR didn't add changes that I had in my mind for this issue so let's keep it open for now.

@Apisov Apisov transferred this issue from covidwatchorg/covidwatch-android-tcn Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants