Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(matchexpr): expose 'isAgent' field for evaluation #598

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Aug 9, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: cryostatio/cryostat-web#1320

Before:

image

After:

image

@andrewazores
Copy link
Member Author

/build_test

Copy link

github-actions bot commented Aug 9, 2024

Workflow started at 8/9/2024, 2:32:26 PM. View Actions Run.

Copy link

github-actions bot commented Aug 9, 2024

No GraphQL schema changes detected.

Copy link

github-actions bot commented Aug 9, 2024

No OpenAPI schema changes detected.

Copy link

github-actions bot commented Aug 9, 2024

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/10324010200

Copy link
Member

@mwangggg mwangggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrewazores andrewazores merged commit f319134 into cryostatio:main Aug 9, 2024
17 of 19 checks passed
@andrewazores andrewazores deleted the matchexpr-is-agent branch August 9, 2024 20:53
mergify bot pushed a commit that referenced this pull request Aug 9, 2024
andrewazores added a commit that referenced this pull request Aug 9, 2024
…#599)

* fix(matchexpr): expose 'isAgent' field for evaluation (#598)

(cherry picked from commit f319134)

* chore(schema): automatic update

---------

Co-authored-by: Andrew Azores <[email protected]>
Co-authored-by: Cryostat CI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Topology and Match Expressions cannot use target agent field
2 participants