-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): replace direct fabric8 kubernetes-client with quarkus kubernetes-client #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
added
dependencies
Pull requests that update a dependency file
fix
safe-to-test
labels
Aug 14, 2024
github-actions
bot
added
the
needs-triage
Needs thorough attention from code reviewers
label
Aug 14, 2024
andrewazores
removed
the
needs-triage
Needs thorough attention from code reviewers
label
Aug 14, 2024
/build_test |
Workflow started at 8/14/2024, 10:35:03 AM. View Actions Run. |
No OpenAPI schema changes detected. |
No GraphQL schema changes detected. |
CI build and push: All tests pass ✅ |
ebaron
approved these changes
Aug 14, 2024
andrewazores
added a commit
to andrewazores/cryostat3
that referenced
this pull request
Oct 8, 2024
7 tasks
andrewazores
added a commit
that referenced
this pull request
Nov 21, 2024
* build(deps): update Quarkus to 3.8 LTS (#609) * build(deps): update Quarkus to 3.8 LTS * add hibernate format mapper override * remove no longer necessary lazy init * disable openapi management / swagger UI unless in dev mode * remove duplicate healthcheck override * reduce healthcheck start periods * correct healthcheck URL * use authproxy image which contains wget for healthcheck * correct healthchecks for vertx agent test applications * build(deps): replace direct fabric8 kubernetes-client with quarkus kubernetes-client (#606) * compose fixup * graphql test fixup * auth proxy fixup * startup discovery transactions * chore(schema): automatic update --------- Co-authored-by: Cryostat CI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
See #605
Description of the change:
Replaces the Fabric8 Kubernetes Client dependency with an equivalent Quarkus Kubernetes Client extension dependency. This uses the Quarkus BOM version so the dependency is kept at an appropriate version compatible with the Quarkus version, including usability in native mode (not relevant at this time, but interesting).
Motivation for the change:
Since #601 , Cryostat fails to start on Kubernetes/OpenShift when Kubernetes API discovery is enabled:
How to manually test:
quay.io/andrewazores/cryostat:quarkus-k8s-client-1
helm install cryostat --set authentication.openshift.enabled=true --set core.route.enabled=true --set core.image.repository=quay.io/andrewazores/cryostat --set core.image.tag=quarkus-k8s-client-1 --set pvc.enabled=true ./charts/cryostat/