Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): verify bot commits for schema changes #613

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Aug 20, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Part of: #577

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

@aali309 aali309 added feat New feature or request safe-to-test labels Aug 20, 2024
@aali309 aali309 self-assigned this Aug 20, 2024
@aali309
Copy link
Contributor Author

aali309 commented Aug 20, 2024

sample run : aali309#39
Before
image

After
image

@aali309 aali309 requested a review from andrewazores August 20, 2024 18:56
@andrewazores andrewazores merged commit 8f0e455 into cryostatio:main Aug 20, 2024
13 checks passed
@aali309 aali309 deleted the verifyBotCommits branch August 20, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants