-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remaining problem in unisusie pipeline #527
Comments
@SamuelSun2000 could you provide me a minimal working example for this? (remember the style of the RNA-seq protocol you have tried last year we have the MWE). I'm swamped today until late in the PM .. but this one is now on the top of my TODO to finalize so others can use. |
I see. @SamuelSun2000 the MWE you provided me can they reproduce these issues? |
Yes, both of them. |
I was thinking, perhaps we should take away the uni_susie_2/3 altogether. And make the transform to vcf step another utility in the susie_post_proc notebook. Along with the code that produces the three summary tables. |
yes i remember your proposal. let me take a look maybe this evening or tmr |
@hsun3163 Please note that
uni_susie_2
in https://github.com/cumc/xqtl-pipeline/blob/main/code/fine_mapping/SuSiE/SuSiE.ipynb cannot be successfully executed yet. There are two problems:improt os; skip_if(os.path.getsize(_input) == 0)
may help.susie_list
inuni_susie_2
. We no longer can usesusie_list[[i]]$pip
to extract pip. Instead, we should directly usesusie_list$pip
.Because I currently don't know the strategy for correcting this step -- whether I should make a vcf for per gene per tissue, or integrate the result per gene in all tissues. So I leave this issue here as a reminder.
The text was updated successfully, but these errors were encountered: