Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit commitizen not working anymore #384

Open
1 task done
anmoel opened this issue Sep 21, 2023 · 2 comments · May be fixed by #474
Open
1 task done

pre-commit commitizen not working anymore #384

anmoel opened this issue Sep 21, 2023 · 2 comments · May be fixed by #474
Assignees
@chris-ruecker
Labels
bug Something isn't working

Comments

@anmoel
Copy link
Member

anmoel commented Sep 21, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

x

Nexus Provider Version

x

Nexus Version

x

Affected Resource(s)/Data Source(s)

x

Terraform Configuration Files

x

Debug Output/Panic Output

x

Expected Behaviour

a commit with message "testcommit" should fail throw the pre-commit hook commitizen

Actual Behaviour

it's not failing

Steps to Reproduce

pre-commit install
touch testfile
git add testfile
git commit -m "testcommit"

References

No response
@anmoel anmoel added the bug Something isn't working label Sep 21, 2023
@chris-ruecker chris-ruecker self-assigned this Oct 10, 2024
@chris-ruecker chris-ruecker linked a pull request Oct 10, 2024 that will close this issue
Open
@chris-ruecker chris-ruecker linked a pull request Oct 10, 2024 that will close this issue
chore: add setup make command #474
Open
@chris-ruecker
Copy link
Contributor

chris-ruecker commented Oct 10, 2024 •
edited
Loading

One has to run:
pre-commit install --hook-type commit-msg --hook-type pre-push for the commitizen hooks to work properly.
Running install without specifying hook types is not enough.

https://commitizen-tools.github.io/commitizen/getting_started/#integration-with-pre-commit

@stevie-
Copy link
Collaborator

stevie- commented Oct 11, 2024

I want to bring up the discussion, if commitizen is still the best tool for the job?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chris-ruecker chris-ruecker

Labels
bug Something isn't working
Projects
Nexus Terraform Provider
Status: In process
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add setup make command datadrivers/terraform-provider-nexus
3 participants
@stevie- @anmoel @chris-ruecker