Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace jsonschema validation with fastjsonschema validation #145

Closed
gshank opened this issue Jun 1, 2024 · 2 comments · May be fixed by #146
Closed

Replace jsonschema validation with fastjsonschema validation #145

gshank opened this issue Jun 1, 2024 · 2 comments · May be fixed by #146
Labels
Stale

Comments

@gshank
Copy link
Contributor

gshank commented Jun 1, 2024

Description

For performance reason we are replacing jsonschema validation with fastjsonschema.

This requires changes to the main "validate" method in dataclass_schema.py, dbtClassMixin. Since we subclasses jsonschema.ValidationError with our own ValidationError class, we need to make some changes to enable a ValidationError class based on fastjsonschema.JsonSchemaValueException.

Acceptance Criteria

Parsing is faster. Validation error messages are acceptable.
@gshank gshank mentioned this issue Jun 1, 2024
Open
5 tasks
@github-actions GitHub Actions
Copy link

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use fastjsonschema instead of jsonschema for validation dbt-labs/dbt-common
1 participant
@gshank