Skip to content
This repository has been archived by the owner on May 11, 2023. It is now read-only.

Generate 'emits_changed_signal' property - [opened] #400

Open
zeenix opened this issue Feb 17, 2023 · 6 comments
Open

Generate 'emits_changed_signal' property - [opened] #400

zeenix opened this issue Feb 17, 2023 · 6 comments

Comments

@zeenix
Copy link
Collaborator

zeenix commented Feb 17, 2023

In GitLab by @RDruon on Feb 17, 2023, 16:34

Merges emits_changed_signal -> main

Generate #[dbus_proxy(property(emits_changed_signal = "$VALUE"))]/#[dbus_proxy(property(emits_changed_signal = "$VALUE"), name = "$NAME")] based on annotations value.

@zeenix
Copy link
Collaborator Author

zeenix commented Feb 17, 2023

Why create a new PR for the same exact thing? 🤔 You know you can just force push your completely new changes to the same branch, right?

@zeenix
Copy link
Collaborator Author

zeenix commented Feb 18, 2023

Please rebase on latest main for fixing the CI.

@zeenix
Copy link
Collaborator Author

zeenix commented Feb 20, 2023

In GitLab by @RDruon on Feb 20, 2023, 09:00

Sorry about that, I messed up the fork and wasn't able to push on the same PR

@zeenix
Copy link
Collaborator Author

zeenix commented Feb 20, 2023

In GitLab by @RDruon on Feb 20, 2023, 09:01

added 8 commits

  • 24e52965...396d65ab - 7 commits from branch dbus:main
  • 9f9e8ad - Generate 'emits_changed_signal' property

Compare with previous version

@zeenix
Copy link
Collaborator Author

zeenix commented Feb 20, 2023

resolved all threads

@zeenix
Copy link
Collaborator Author

zeenix commented Feb 20, 2023

  • Without updates to the tests and/or docs, it's a bit hard to tell what this PR does.
  • Also the PR description isn't very clear to me. Could you please expand a bit there.
  • Also, please always add description(s) to commit log(s) too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant