You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the documentation lists too many dependencies to let users install manually, which is too complex. These packages should be added to dependencies and installed automatically.
mdtraj and rdkit are available in PyPI, so they can also listed as dependencies. Users only need to manually install openmm, which is blocked by openmm/openmm#3796.
Considering that OpenMM is a mandatory dependency for dmff, it is reasonable to assume that most users already have conda installed. Also, the dmff dependencies can be primarily configured within conda.
In the future, dmff is expected to include binary files for OpenMM plugins, as developing with conda in https://github.com/deepmodeling/DMFF/tree/devel/backend. Given this, I recommend using conda recipes directly for distributing dmff instead of PyPI.
In addition, it is also worth considering whether a separate distribution of OpenMMDMFFPlugin(if named as such) is necessary.
When building a conda recipe, one still needs to use pip install to install the package and may use pip check to check whether the dependencies are correctly installed. Only writing dependencies to the conda recipe is unsafe.
Summary
Make DMFF available via
pip install dmff
.Motivation
Currently, the documentation lists too many dependencies to let users install manually, which is too complex. These packages should be added to dependencies and installed automatically.
mdtraj
andrdkit
are available in PyPI, so they can also listed as dependencies. Users only need to manually install openmm, which is blocked by openmm/openmm#3796.Suggested Solutions
Further Information, Files, and Links
No response
The text was updated successfully, but these errors were encountered: