Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow typing performance on long emails #65

Closed
sbrudz opened this issue Feb 10, 2020 · 1 comment · Fixed by #75
Closed

Slow typing performance on long emails #65

sbrudz opened this issue Feb 10, 2020 · 1 comment · Fixed by #75
Assignees
Labels

Comments

@sbrudz
Copy link
Contributor

sbrudz commented Feb 10, 2020

While testing the last few pull requests, I've noticed that typing into long emails is very laggy. I profiled the code and found that the checkForWarnings function in just-not-sorry is the culprit. It adds and removes the warnings each time you type a character. This causes Chrome to recalculate the layout of the DOM over and over again, which is slow when there are a lot of nodes being impacted. We should implement a less expensive method of handling warnings to address this issue. The changes needed to fix this issue could also serve as a base for being able to implement #59 .
just-not-sorry-profile

@maniacialexa
Copy link

In progress - 2 days thus far writing tests because we were missing test coverage. About another day of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants