Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #8

Open
3 tasks
derekdowling opened this issue Nov 19, 2014 · 0 comments
Open
3 tasks

Feedback #8

derekdowling opened this issue Nov 19, 2014 · 0 comments

Comments

@derekdowling
Copy link
Owner

  • is_a() please use the language construct instanceof its faster.
  • Stubborn.php#L233 You want self:: I think rather than static::
  • Your using Exceptions for your events.. seems abit fugly.. quick fix solution might be a have an EventException, throw new EventException(Event::STOP_TIMING), rather than having a class called "StopEvent" which actually extends an Exception but doesn't live in the Exception folder or named "StopEventException".. even then this seems odd using Exceptions for Events. using the Symfony EventDispatcher would be Ideal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant