-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add richer card theme support #1809
base: main
Are you sure you want to change the base?
Conversation
BREAKING CHANGE: Alters the behavior and renames the previous `view.dark_mode` parameter to `view.dim`. Now behaves separately from choice of theme.
@felipecrs If you have time, would you mind trying this out? It's changes the theming of the default card, so a second pair of eyes would be good. view:
theme:
themes:
- ha // <--- Can set this value to any of ['ha', 'dark', 'light', 'traditional']. |
I do not see any difference: chrome_D0SaXcqN0M.mp4Is this expected? |
Oh, never mind! It was a caching issue. |
But is this expected? chrome_NBXmTHaMji.mp4I suppose |
Thanks for testing! Yes, I think that looks roughly as intended:
When in |
I'll add: It might not seem like a big difference, but this lets us define entirely new themes in future with minimal changes, and allows for overrides of CSS parameters within a theme (e.g. "I want my menu red but everything else the same"). I'm mostly concerned with getting the default theme to look well :-) |
Right. Maybe you can tweak This would allow users a more seamless transition, while still giving them the chance of trying the new theme and provide feedback. |
Or, if you are keen to, to prevent a breaking change (and thus a new major release), you can retain support for the |
@felipecrs Changed
100% understand the spirit of that question, but I think if we're to embrace the conventional commits / semantic releases approach, we need to lose the "romantic" meaning of major version change, and stick with just the backwards-incompatible meaning. No point in hiding from it, even though I am sure people will complain :-) |
BREAKING CHANGE: Alters the behavior and renames the previous
view.dark_mode
parameter toview.dim
. Now behaves separately from choice of theme.dark
andlight
theme support #1796state_color
#1793