Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify difference between mappings #326

Open
Tracked by #204
adrienbanse opened this issue Nov 24, 2023 · 1 comment
Open
Tracked by #204

Clarify difference between mappings #326

adrienbanse opened this issue Nov 24, 2023 · 1 comment

Comments

@adrienbanse
Copy link
Collaborator

adrienbanse commented Nov 24, 2023 •
edited by blegat
Loading

Clarify difference between mappings in src/mapping and xpos2int etc. in symbolic models (@egidioln could you help us with that? Is it really necessary that mapping is a distinct folder in the codebase?)
@adrienbanse adrienbanse mentioned this issue Nov 24, 2023
Closed
15 tasks
@blegat blegat changed the title Clarify difference between mappings in src/mapping and xpos2int etc. in symbolic models (@egidioln could you help us with that? Is it really necessary that mapping is a distinct folder in the codebase?) Clarify difference between mappings Nov 30, 2023
@egidioln
Copy link
Collaborator

egidioln commented Dec 4, 2023

Hey, sorry, I didn't se the tag...

As I said here, #204 (comment), Mapping would be a general (abstract) type that many others could inherit from (such as one implementing xpos2int)... But, again, I have no strong feeling that this is the best option so feel free to remove it if it doesn't make sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@egidioln @adrienbanse